From cbfa17d446effcfc1e7d17aed624af8f098370f1 Mon Sep 17 00:00:00 2001
From: rodri <rgl@antares-labs.eu>
Date: Thu, 23 May 2024 21:26:19 +0000
Subject: get rid of rendering latency by decoupling it from i/o.

i was using a single alternator to mux both i/o and drawing
in a single proc, and avoid locking. the problem is that it
causes a fight to break up every time there's any input
(steady 100Hz) or a lot of drawing requests from the
renderer (up to 60Hz.)

i added a drawproc to handle exclusively drawing requests,
 and a drawing lock for UI widgets that kidnap the display.
---
 med.c | 52 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 40 insertions(+), 12 deletions(-)

(limited to 'med.c')

diff --git a/med.c b/med.c
index 670997a..0e49f44 100644
--- a/med.c
+++ b/med.c
@@ -76,6 +76,7 @@ Entity *subject;
 Model *model;
 Shadertab *shader;
 QLock scenelk;
+QLock drawlk;
 Mouse om;
 Quaternion orient = {1,0,0,0};
 
@@ -466,11 +467,11 @@ redraw(void)
 }
 
 void
-drawproc(void *)
+renderproc(void *)
 {
 	uvlong t0, Δt;
 
-	threadsetname("drawproc");
+	threadsetname("renderproc");
 
 	t0 = nsec();
 	for(;;){
@@ -491,6 +492,18 @@ drawproc(void *)
 	}
 }
 
+void
+drawproc(void *)
+{
+	threadsetname("drawproc");
+
+	for(;;)
+		if(recv(drawc, nil) && canqlock(&drawlk)){
+			redraw();
+			qunlock(&drawlk);
+		}
+}
+
 void
 lmb(void)
 {
@@ -516,6 +529,7 @@ mmb(void)
 	};
 	static Menu menu = { .item = items };
 
+	qlock(&drawlk);
 	switch(menuhit(2, mctl, &menu, _screen)){
 	case TSNEAREST:
 		tsampler = neartexsampler;
@@ -526,35 +540,50 @@ mmb(void)
 	case QUIT:
 		threadexitsall(nil);
 	}
+	qunlock(&drawlk);
 	nbsend(drawc, nil);
 }
 
 static char *
 genrmbmenuitem(int idx)
 {
+	static char *items[] = {
+		"",
+		"add cube",
+		nil
+	};
 	if(idx < nelem(shadertab))
 		return shadertab[idx].name;
-	else if(idx == nelem(shadertab))
-		return "";
-	else if(idx == nelem(shadertab)+1)
-		return "add cube";
-	return nil;
+	idx -= nelem(shadertab);
+	return items[idx];
 }
 
 void
 rmb(void)
 {
+	enum {
+		SP,
+		ADDCUBE,
+	};
 	static Menu menu = { .gen = genrmbmenuitem };
 	int idx;
 
+	qlock(&drawlk);
 	idx = menuhit(3, mctl, &menu, _screen);
 	if(idx < 0)
-		return;
+		goto nohit;
 	if(idx < nelem(shadertab)){
 		shader = &shadertab[idx];
 		memset(&cam.stats, 0, sizeof(cam.stats));
-	}else if(idx == nelem(shadertab)+1)
+	}
+	idx -= nelem(shadertab);
+	switch(idx){
+	case ADDCUBE:
 		addcube();
+		break;
+	}
+nohit:
+	qunlock(&drawlk);
 	nbsend(drawc, nil);
 }
 
@@ -763,22 +792,21 @@ threadmain(int argc, char *argv[])
 
 	proccreate(kbdproc, nil, mainstacksize);
 	proccreate(keyproc, keyc, mainstacksize);
+	proccreate(renderproc, nil, mainstacksize);
 	proccreate(drawproc, nil, mainstacksize);
 
 	for(;;){
-		enum {MOUSE, RESIZE, KEY, DRAW};
+		enum {MOUSE, RESIZE, KEY};
 		Alt a[] = {
 			{mctl->c, &mctl->Mouse, CHANRCV},
 			{mctl->resizec, nil, CHANRCV},
 			{keyc, nil, CHANRCV},
-			{drawc, nil, CHANRCV},
 			{nil, nil, CHANEND}
 		};
 		switch(alt(a)){
 		case MOUSE: mouse(); break;
 		case RESIZE: resize(); break;
 		case KEY: handlekeys(); break;
-		case DRAW: redraw(); break;
 		}
 	}
 }
-- 
cgit v1.2.3